openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Information



Diff comments:

> 
> === modified file 'openlp/core/ui/lib/listwidgetwithdnd.py'
> --- openlp/core/ui/lib/listwidgetwithdnd.py	2016-04-17 19:09:46 +0000
> +++ openlp/core/ui/lib/listwidgetwithdnd.py	2016-11-11 21:08:21 +0000
> @@ -26,7 +26,10 @@
>  
>  from PyQt5 import QtCore, QtGui, QtWidgets
>  
> -from openlp.core.common import Registry
> +from openlp.core.common import Registry, translate
> +
> +NO_RESULTS = translate('OpenLP.ListWidgetWithDnD', 'No Search Results')
> +SHORT_RESULTS = translate('OpenLP.ListWidgetWithDnD', 'Please type more text to use \'Search As You Type\'')
>  

Does this work for translating? I think this gets loaded too early for the translation system to actually kick in. Use UiStrings() instead.

>  
>  class ListWidgetWithDnD(QtWidgets.QListWidget):


-- 
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310690
Your team OpenLP Core is subscribed to branch lp:openlp.