openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Question inline

Diff comments:

> 
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py	2016-09-16 21:43:30 +0000
> +++ openlp/plugins/bibles/lib/mediaitem.py	2016-11-11 21:35:00 +0000
> @@ -444,15 +444,7 @@
>          only updated when we are doing reference or combined search, in text search the completion list is removed.
>          """
>          log.debug('update_auto_completer')
> -        # Save the current search type to the configuration. If setting for automatically resetting the search type to
> -        # Combined is enabled, use that otherwise use the currently selected search type.
> -        # Note: This setting requires a restart to take effect.
> -        if Settings().value(self.settings_section + '/reset to combined quick search'):
> -            Settings().setValue('{section}/last search type'.format(section=self.settings_section),
> -                                BibleSearch.Combined)
> -        else:
> -            Settings().setValue('{section}/last search type'.format(section=self.settings_section),
> -                                self.quick_search_edit.current_search_type())
> +        # TODO: Move this else where?

What is wrong with here then?  if this is the place to make the change,

>          # Save the current bible to the configuration.
>          Settings().setValue('{section}/quick bible'.format(section=self.settings_section),
>                              self.quickVersionComboBox.currentText())


-- 
https://code.launchpad.net/~phill-ridout/openlp/search_edit/+merge/310691
Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/search_edit into lp:openlp.