openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/hide-projectors-2.4 into lp:openlp/2.4.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/hide-projectors-2.4/+merge/315303

We're getting quite a few support tickets from people who think the Projector Manager is for setting up OpenLP's display. Hiding the projector manager by default should prevent this from happening as often as it currently is.
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/hide-projectors-2.4 into lp:openlp/2.4.

=== modified file 'openlp/core/ui/mainwindow.py'
--- openlp/core/ui/mainwindow.py	2016-12-31 11:05:48 +0000
+++ openlp/core/ui/mainwindow.py	2017-01-21 21:08:26 +0000
@@ -176,6 +176,7 @@
         self.projector_manager_contents = ProjectorManager(self.projector_manager_dock)
         self.projector_manager_contents.setObjectName('projector_manager_contents')
         self.projector_manager_dock.setWidget(self.projector_manager_contents)
+        self.projector_manager_dock.setVisible(False)
         main_window.addDockWidget(QtCore.Qt.RightDockWidgetArea, self.projector_manager_dock)
         # Create the menu items
         action_list = ActionList.get_instance()

=== modified file 'tests/functional/openlp_core_ui/test_mainwindow.py'
--- tests/functional/openlp_core_ui/test_mainwindow.py	2016-12-31 11:05:48 +0000
+++ tests/functional/openlp_core_ui/test_mainwindow.py	2017-01-21 21:08:26 +0000
@@ -156,6 +156,15 @@
         self.assertTrue('plugin_manager' in self.registry.service_list,
                         'The plugin_manager should have been registered.')
 
+    def test_projector_dock_hidden_by_default(self):
+        """
+        Test that the projector dock is hidden by default
+        """
+        # GIVEN: A main window
+        # WHEN: OpenLP starts
+        # THEN: The projector dock is hidden
+        self.main_window.projector_manager_dock.setVisible.assert_called_once_with(False)
+
     def on_search_shortcut_triggered_shows_media_manager_test(self):
         """
         Test that the media manager is made visible when the search shortcut is triggered