← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

To: mp+321504@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Fri, 31 Mar 2017 05:49:00 -0000
In-reply-to: <20170331011923.31605.88919.launchpad@ackee.canonical.com>
Reply-to: mp+321504@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hey Gary, there's an easier way to do your _find_files method. Use the os.walk() function. Also, if may be president to have a maximum depth just in case the user selected an incorrect directory. 
-- 
https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp
From: Gary Talent, 2017-03-31