openlp-core team mailing list archive

[Gary Talent <gtalent2@xxxxxxxxx>]

I don't think the os.walk() option is quite the same. That would iterate over every file and directory in the base EW6 directory, but we know it's a much more limited set of options. It has to be Databases/Data/Songs.db, Data/Songs.db, or Songs.db. Also, if the user was at some point messing around in the EW6 directory and made a copy of the Databases or Databases/Data directories, the os.walk() solution could pick up the wrong files. Switching to os.walk() would only save about 5 lines of code, and it would be less efficient and introduce a possible bug.
-- 
https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504
Your team OpenLP Core is subscribed to branch lp:openlp.