openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

To: mp+321504@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <second@xxxxxx>
Date: Thu, 18 May 2017 09:05:06 -0000
In-reply-to: <20170331011923.31605.88919.launchpad@ackee.canonical.com>
Reply-to: mp+321504@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Just wanted to add something to the discussion...
I've had a look at the EW6 song DB that triggered the RTF vs labels discussion...
As you state we strip out RTF tags that could be used to identify label. Normally it works out anyway, because we use the language of OpenLP to look for the localized tag names. That didn't work in this particular case because the translations isn't active/included in normal development setup, and we don't actually have translations for this particular language!

So in summary, I think we should ignore this issue, since for most users it won't be an issue.
-- 
https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp
From: Gary Talent, 2017-03-31