← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

To: mp+325035@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <second@xxxxxx>
Date: Sun, 04 Jun 2017 06:06:41 -0000
In-reply-to: <20170603105925.19004.15881.launchpad@ackee.canonical.com>
Reply-to: mp+325035@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hi Johannes,

Thank you for contributing to OpenLP!
To get your code merged you must create a test that proves it actually works. Have a look at the wiki for inspiration: https://wiki.openlp.org/Development:Unit_Tests
-- 
https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325035
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp
From: Johannes Thomas Meyer, 2017-06-03