openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

To: mp+325043@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 04 Jun 2017 14:47:32 -0000
In-reply-to: <20170604135225.8946.7347.launchpad@ackee.canonical.com>
Reply-to: mp+325043@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

You need to run CI on this to show the success of tests.
Not sure why but this request did a full download when I did a check out.  Also cannot run due to chord issues.
Cannot run this but there seem to be lots of line breaks in the footer display. As the footer area is small this will not be displayed and lead to forum comments.
You need some validation do defend against too long footers!  
-- 
https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp
From: Samuel Mehrbrodt, 2017-06-04