openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Just some minor things.

Also, I really would prefer to see 1 new test, not just updates to tests.

Diff comments:

> 
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py	2017-05-07 18:39:17 +0000
> +++ openlp/plugins/bibles/lib/mediaitem.py	2017-06-05 03:11:16 +0000
> @@ -414,7 +414,7 @@
>              if self.bible:
>                  book_data = self.get_common_books(self.bible, self.second_bible)
>                  language_selection = self.plugin.manager.get_language_selection(self.bible.name)
> -                books = [book.get_name(language_selection) for book in book_data]
> +                books = [book.get_name(language_selection) + ' ' for book in book_data]

Someone is probably going to come and delete this again, so maybe just put a comment above this line explaining why there's a space here?

>                  books.sort(key=get_locale_key)
>          set_case_insensitive_completer(books, self.search_edit)
>  
> 
> === modified file 'openlp/plugins/songs/forms/duplicatesongremovalform.py'
> --- openlp/plugins/songs/forms/duplicatesongremovalform.py	2016-12-31 11:01:36 +0000
> +++ openlp/plugins/songs/forms/duplicatesongremovalform.py	2017-06-05 03:11:16 +0000
> @@ -82,6 +82,9 @@
>          self.finish_button.clicked.connect(self.on_wizard_exit)
>          self.cancel_button.clicked.connect(self.on_wizard_exit)
>  
> +    def closeEvent(self, event):
> +            self.on_wizard_exit()

Indented too far

> +
>      def add_custom_pages(self):
>          """
>          Add song wizard specific pages.


-- 
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325053
Your team OpenLP Core is subscribed to branch lp:openlp.