openlp-core team mailing list archive

[Phill <1209515@xxxxxxxxxxxxxxxxxx>]

I've tested on Ubuntu 17.04 (Unity) and Windows 7.

Anybody with KDE, just to round up testing?

On Thu, 15 Jun 2017, 02:36 David Wales, <daviewales@xxxxxxxxx> wrote:

> Tested on OS X El Capitan with python 3, and PyQt 5 installed using
> brew.
>
> Works perfectly.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1209515
>
> Title:
>   getFileNames corrupts file names that use "special chars"
>
> Status in OpenLP:
>   Fix Released
> Status in OpenLP 2.0 series:
>   Fix Released
> Status in OpenLP trunk series:
>   Fix Released
>
> Bug description:
>   This is a little bit of a strange one. I have written a little script
>   which demonstrates this (I'll include it when I get home).
>
>
>   Here's the issue:
>
>   Use QFileDialog.getFileNames() to select a single file with a special
>   char in its name (a '#' will do it) and it returns the file name &
>   path correctly. Ie selecting a file called "#123.xml" returns a list
>   with one item "#123.xml"
>
>   However, use QFileDialog.getFileNames() to select multiple files with
>   at lease one file with special char in its name (a '#' will do it) and
>   it returns the file name & path incorrectly. Ie selecting a file
>   called "#123.xml" and a file called "abc.xml" returns a list with two
>   items "%23123.xml" & "abc.xml" (Note the # has been changed in to a
>   %23. Possible url encoding?)
>
>   When we come to open the file, Python cannot find the file
>   "%23123.xml" because it does not exist.
>
>   This seams to be a Qt bug (I've done a few searches, but found
>   nothing) but we could at least make some effort to see if the file
>   actually exists before trying to open it!
>
>   Reported here: http://support.openlp.org/issues/2056
>   and here: http://support.openlp.org/issues/1964
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openlp/+bug/1209515/+subscriptions
>

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1209515

Title:
  getFileNames corrupts file names that use "special chars"

Status in OpenLP:
  Fix Released
Status in OpenLP 2.0 series:
  Fix Released
Status in OpenLP trunk series:
  Fix Released

Bug description:
  This is a little bit of a strange one. I have written a little script
  which demonstrates this (I'll include it when I get home).

  
  Here's the issue:

  Use QFileDialog.getFileNames() to select a single file with a special
  char in its name (a '#' will do it) and it returns the file name &
  path correctly. Ie selecting a file called "#123.xml" returns a list
  with one item "#123.xml"

  However, use QFileDialog.getFileNames() to select multiple files with
  at lease one file with special char in its name (a '#' will do it) and
  it returns the file name & path incorrectly. Ie selecting a file
  called "#123.xml" and a file called "abc.xml" returns a list with two
  items "%23123.xml" & "abc.xml" (Note the # has been changed in to a
  %23. Possible url encoding?)

  When we come to open the file, Python cannot find the file
  "%23123.xml" because it does not exist.

  This seams to be a Qt bug (I've done a few searches, but found
  nothing) but we could at least make some effort to see if the file
  actually exists before trying to open it!

  Reported here: http://support.openlp.org/issues/2056
  and here: http://support.openlp.org/issues/1964

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1209515/+subscriptions