← Back to team overview

openlp-core team mailing list archive

[Bug 1698291] Re: Better feedback for incorrect Bible format

 

How clever does the fix need to be?

Would something like the following in bibleimportform.py, or osis.py be
adequate?

`try:
     someFunctions()
 except AssertionError as err:
     displayErrorBox()`

Or are you looking for something a bit cleverer?

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1698291

Title:
  Better feedback for incorrect Bible format

Status in OpenLP:
  Confirmed

Bug description:
  We get a few of these every month in the support system. Someone who
  tries to import their Bible in who knows what format and just goes
  with the default format (which I am led to believe is OSIS). I know
  it's not our fault, but let's catch this exception and tell the user
  that they're using the wrong format.

   --- Exception Traceback ---
  Traceback (most recent call last):
  File "openlp\core\ui\wizard.py", line 216, in on_current_id_changed
  File "openlp\plugins\bibles\forms\bibleimportform.py", line 632, in perform_wizard
  File "openlp\plugins\bibles\lib\osis.py", line 65, in do_import
  File "lxml.etree.pyx", line 2182, in lxml.etree._ElementTree.xpath (src\lxml\lxml.etree.c:59945)
  File "lxml.etree.pyx", line 1778, in lxml.etree._ElementTree._assertHasRoot (src\lxml\lxml.etree.c:55819)
  AssertionError: ElementTree not initialized, missing root

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1698291/+subscriptions


References