openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'openlp/core/__init__.py'
> --- openlp/core/__init__.py	2017-05-30 18:42:35 +0000
> +++ openlp/core/__init__.py	2017-06-21 22:02:37 +0000
> @@ -33,6 +33,8 @@
>  import shutil
>  import sys
>  import time
> +from patches.shutilpatches import copytree
> +from pathlib2 import Path

Why? pathlib2 is just a backport of pathlib that is included in Python 3.4 and up to earlier versions of Python (not to mention I'm not sure why we're moving to pathlib, as I don't see it offering any advantages over os.path).

>  from traceback import format_exception
>  
>  from PyQt5 import QtCore, QtGui, QtWidgets


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/325905
Your team OpenLP Core is subscribed to branch lp:openlp.