openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See inline comments.
Please fix the commit comments to reflect the changes as they refer to #noqa which has been removed.  (There may be more).

Diff comments:

> 
> === modified file 'openlp/core/lib/projector/pjlink1.py'
> --- openlp/core/lib/projector/pjlink1.py	2017-06-17 00:25:06 +0000
> +++ openlp/core/lib/projector/pjlink1.py	2017-07-12 13:16:20 +0000
> @@ -262,6 +277,38 @@
>              self.send_command('INF2', queue=True)
>          if self.pjlink_name is None:
>              self.send_command('NAME', queue=True)
> +        if self.pjlink_class == '2':
> +            # Class 2 specific checks
> +            if self.serial_no is None:
> +                self.send_command('SNUM', queue=True)
> +            if self.sw_version is None:
> +                self.send_command('SVER', queue=True)
> +            if self.model_filter is None:
> +                self.send_command('RFIL', queue=True)
> +            if self.model_lamp is None:
> +                self.send_command('RLMP', queue=True)
> +
> +    def process_rfil(self, data):

Where is this called from?

> +        """
> +        Process replacement filter type
> +        """
> +        if self.model_filter is None:
> +            self.model_filter = data
> +        else:
> +            log.warn("({ip}) Filter model already set".format(ip=self.ip))
> +            log.warn("({ip}) Saved model: '{old}'".format(ip=self.ip, old=self.model_filter))
> +            log.warn("({ip}) New model: '{new}'".format(ip=self.ip, new=data))
> +
> +    def process_rlmp(self, data):

Where is this called from?

> +        """
> +        Process replacement lamp type
> +        """
> +        if self.model_lamp is None:
> +            self.model_lamp = data
> +        else:
> +            log.warn("({ip}) Lamp model already set".format(ip=self.ip))
> +            log.warn("({ip}) Saved lamp: '{old}'".format(ip=self.ip, old=self.model_lamp))
> +            log.warn("({ip}) New lamp: '{new}'".format(ip=self.ip, new=data))
>  
>      def _get_status(self, status):
>          """


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-f/+merge/327290
Your team OpenLP Core is subscribed to branch lp:openlp.