openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See inline

Diff comments:

> 
> === modified file 'openlp/core/lib/pluginmanager.py'
> --- openlp/core/lib/pluginmanager.py	2017-08-01 20:59:41 +0000
> +++ openlp/core/lib/pluginmanager.py	2017-08-12 19:11:29 +0000
> @@ -69,7 +69,7 @@
>          """
>          Scan a directory for objects inheriting from the ``Plugin`` class.
>          """
> -        glob_pattern = os.path.join('openlp', 'plugins', '*', '*plugin.py')
> +        glob_pattern = os.path.join('plugins', '*', '*plugin.py')

Why the change.  I noticed openlp being added above and wonder why.

>          extension_loader(glob_pattern)
>          plugin_classes = Plugin.__subclasses__()
>          plugin_objects = []
> 
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py	2017-05-30 18:50:39 +0000
> +++ openlp/core/ui/media/mediacontroller.py	2017-08-12 19:11:29 +0000
> @@ -174,7 +174,7 @@
>          Check to see if we have any media Player's available.
>          """
>          log.debug('_check_available_media_players')
> -        controller_dir = os.path.join('openlp', 'core', 'ui', 'media')
> +        controller_dir = os.path.join('core', 'ui', 'media')
>          glob_pattern = os.path.join(controller_dir, '*player.py')

AN this one?

>          extension_loader(glob_pattern, ['mediaplayer.py'])
>          player_classes = MediaPlayer.__subclasses__()


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950
Your team OpenLP Core is subscribed to branch lp:openlp.