openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

See inline comments.
Also how has AppVeyer been broken it was just fixed!

Diff comments:

> 
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py	2017-08-23 20:13:58 +0000
> +++ openlp/core/ui/media/mediacontroller.py	2017-08-26 14:02:15 +0000
> @@ -433,7 +435,7 @@
>          log.debug('video mediatype: ' + str(controller.media_info.media_type))
>          # dont care about actual theme, set a black background
>          if controller.is_live and not controller.media_info.is_background:
> -            display.frame.evaluateJavaScript('show_video( "setBackBoard", null, null, null,"visible");')
> +            display.frame.evaluateJavaScript('show_video( "setBackBoard", null, null,"visible");')

You remove the space below and not here!

>          # now start playing - Preview is autoplay!
>          autoplay = False
>          # Preview requested


-- 
https://code.launchpad.net/~springermac/openlp/media-fixes/+merge/329664
Your team OpenLP Core is subscribed to branch lp:openlp.