openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Sorry but you removed too much code!

Diff comments:

> 
> === modified file 'openlp/core/common/registry.py'
> --- openlp/core/common/registry.py	2017-03-03 19:27:31 +0000
> +++ openlp/core/common/registry.py	2017-09-18 07:01:04 +0000
> @@ -138,12 +138,9 @@
>                      if result:
>                          results.append(result)
>                  except TypeError:
> -                    # Who has called me can help in debugging
> -                    trace_error_handler(log)

Please leave to help with debugging random calls.

>                      log.exception('Exception for function {function}'.format(function=function))
>          else:
> -            trace_error_handler(log)

See above

> -            log.error("Event {event} called but not registered".format(event=event))
> +            log.exception('Event {event} called but not registered'.format(event=event))
>          return results
>  
>      def get_flag(self, key):


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/330895
Your team OpenLP Core is subscribed to branch lp:openlp.