openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

tests fail on my machine 
Code looks ok!

======================================================================
ERROR: Test the Bible Gateway retrieval of book list for DN1933 bible with redirect (bug 1251437)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tim/Projects/OpenLP/openlp/fix-version-check/tests/interfaces/openlp_plugins/bibles/test_lib_http.py", line 68, in test_bible_gateway_extract_books_support_redirect
    self.assertEqual(len(books), 66, 'This bible should have 66 books')
TypeError: object of type 'NoneType' has no len()
-------------------- >> begin captured logging << --------------------
openlp.core.common.registry: INFO: Registry Initialising
openlp.plugins.bibles.lib.importers.http: DEBUG: BGExtract.init(proxy_url="None")
openlp.plugins.bibles.lib.importers.http: DEBUG: BGExtract.get_books_from_http("DN1933")
openlp.core.common.httputils.__init__: DEBUG: Downloading URL = http://www.biblegateway.com/versions/?action=getVersionInfo&vid=DN1933#books
requests.packages.urllib3.connectionpool: DEBUG: Starting new HTTP connection (1): www.biblegateway.com
requests.packages.urllib3.connectionpool: DEBUG: http://www.biblegateway.com:80 "GET /versions/?action=getVersionInfo&vid=DN1933 HTTP/1.1" 301 278
requests.packages.urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): www.biblegateway.com
requests.packages.urllib3.connectionpool: DEBUG: https://www.biblegateway.com:443 "GET /versions/?action=getVersionInfo&vid=DN1933 HTTP/1.1" 301 None
requests.packages.urllib3.connectionpool: DEBUG: http://www.biblegateway.com:80 "GET /versions/Dette-er-Biblen-p%C3%83%C2%A5-dansk-1933/ HTTP/1.1" 301 278
requests.packages.urllib3.connectionpool: DEBUG: https://www.biblegateway.com:443 "GET /versions/Dette-er-Biblen-p%C3%83%C2%A5-dansk-1933/ HTTP/1.1" 200 None
openlp.core.common.httputils.__init__: DEBUG: Downloaded page https://www.biblegateway.com/versions/Dette-er-Biblen-p%C3%83%C2%A5-dansk-1933/
openlp.plugins.bibles.lib.importers.http: ERROR: No books found in the Biblegateway response.

-- 
https://code.launchpad.net/~raoul-snyman/openlp/fix-version-check/+merge/331243
Your team OpenLP Core is subscribed to branch lp:openlp.