openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

One small request....

Diff comments:

> 
> === modified file 'openlp/core/common/settings.py'
> --- openlp/core/common/settings.py	2017-10-07 07:05:07 +0000
> +++ openlp/core/common/settings.py	2017-11-10 21:03:15 +0000
> @@ -258,6 +258,12 @@
>          ('media/last directory', 'media/last directory', [(str_to_path, None)])
>      ]
>  
> +    __setting_upgrade_3__ = [

Please can we put these into upgrade 2. I want us to keep all the settings upgrades per release together. So all the settings upgrades since 2.4 should be in upgrade 2.

> +        ('songuasge/db password', 'songusage/db password', []),
> +        ('songuasge/db hostname', 'songusage/db hostname', []),
> +        ('songuasge/db database', 'songusage/db database', [])
> +    ]
> +
>      @staticmethod
>      def extend_default_settings(default_values):
>          """


-- 
https://code.launchpad.net/~phill-ridout/openlp/fixes-mkII/+merge/333570
Your team OpenLP Core is subscribed to branch lp:openlp.