openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Just one last tweak.

Diff comments:

> 
> === removed directory 'openlp/core/lib/projector'
> === added directory 'openlp/core/projectors'
> === renamed file 'openlp/core/lib/projector/__init__.py' => 'openlp/core/projectors/__init__.py'
> --- openlp/core/lib/projector/__init__.py	2016-12-31 11:01:36 +0000
> +++ openlp/core/projectors/__init__.py	2017-11-16 16:58:32 +0000
> @@ -25,7 +25,10 @@
>      Initialization for the openlp.core.ui.projector modules.
>  """
>  
> -
> +from .constants import PJLINK_PORT, ERROR_MSG, ERROR_STRING

Make this a fully qualified import if possible please? from openlp.core.projectors.constants import ...

> +
> +
> +# Due to circular dependencies, put the imports after defines

I'm guessing this was the comment you were talking about in IRC?

>  class DialogSourceStyle(object):
>      """
>      An enumeration for projector dialog box type.


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-l/+merge/333832
Your team OpenLP Core is subscribed to branch lp:openlp.