openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

The proposal to merge lp:~raoul-snyman/openlp/better-threading into lp:openlp has been updated.

Description changed to:

Major overhaul of how threading in OpenLP works. Rather than messing around with threads yourself, you create a worker object descended from ThreadWorker, implement start() (and stop() if it's a long-running thread), and run it using run_thread().

Changes related to thread API:

- WebSocket was refactored (mostly into the worker)
- HttpServer was refactored a bit
- CheckMediaWorker was refactored a bit
- Version check refactored
- SongSelect search refactored
- New _wait_for_threads() method in MainWindow
- Tidied up closeEvent in MainWindow a bit

Bugs fixed:

- Logs have returned to the cache dir when XDG is around
- Flipped the --no-web-server flag (now False is off, not on)
- Fixed a call to reload_bibles()

Other things done:

- Removed the --style option (it never worked)
- Renamed "url_get_file() to download_file()
- Standardised a callback object for download_file()


Add this to your merge proposal:
--------------------------------------------------------------------------------
lp:~raoul-snyman/openlp/better-threading (revision 2803)
https://ci.openlp.io/job/Branch-01-Pull/2413/                          [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2314/                  [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/109/                   [SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/32/                   [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-macOS/31/                    [SUCCESS]
https://ci.openlp.io/job/Branch-04a-Code-Analysis/1494/                [SUCCESS]
https://ci.openlp.io/job/Branch-04b-Test-Coverage/1307/                [SUCCESS]
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/258/                 [FAILURE]
Stopping after failure

Failed builds:
 - Branch-05-AppVeyor-Tests #258: https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/258/console

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/better-threading/+merge/335801
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/better-threading into lp:openlp.