openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

I don't forsee pjlink going to a split versioning for class
information (it's not like software), but as you say, space is cheap

On Fri, Jan 12, 2018 at 11:07 PM, Raoul Snyman <raoul@xxxxxxxxxxx> wrote:
> Review: Needs Fixing
>
> I'm pretty happy with this overall, just the field in the database which I think should be bigger.
>
> Diff comments:
>
>> === modified file 'openlp/core/projectors/db.py'
>> --- openlp/core/projectors/db.py      2017-12-29 09:15:48 +0000
>> +++ openlp/core/projectors/db.py      2018-01-13 05:52:32 +0000
>> @@ -152,6 +152,7 @@
>>          location:       Column(String(30))
>>          notes:          Column(String(200))
>>          pjlink_name:    Column(String(128))  # From projector
>> +        pjlink_class    Column(String(1))    # From projector
>
> Just one character? Space is cheap, make it bigger, just in case these classes become something weird like "18.02"
>
>>          manufacturer:   Column(String(128))  # From projector
>>          model:          Column(String(128))  # From projector
>>          other:          Column(String(128))  # From projector
>> @@ -197,6 +199,7 @@
>>      location = Column(String(30))
>>      notes = Column(String(200))
>>      pjlink_name = Column(String(128))
>> +    pjlink_class = Column(String(1))
>
> Same here.
>
>>      manufacturer = Column(String(128))
>>      model = Column(String(128))
>>      other = Column(String(128))
>
>
> --
> https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065
> You are the owner of lp:~alisonken1/openlp/pjlink2-o.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)
OpenLP - Church Projection Software
Empower Your Church http://openlp.org

https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065
Your team OpenLP Core is subscribed to branch lp:openlp.