openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Not happy with the way you are using the settings.

Please Please post deltas of your changes and not rebuild the merge from scratch.

Diff comments:

> 
> === modified file 'openlp/core/projectors/pjlink.py'
> --- openlp/core/projectors/pjlink.py	2018-04-20 06:04:43 +0000
> +++ openlp/core/projectors/pjlink.py	2018-05-03 15:10:54 +0000
> @@ -516,18 +509,22 @@
>          self.lamp = lamps
>          return
>  
> -    def process_lkup(self, data, host, port):
> +    def process_lkup(self, data):
>          """
>          Process reply indicating remote is available for connection
>  
>          :param data: Data packet from remote
> -        :param host: Remote IP address
> -        :param port: Local port packet received on
>          """
> -        # TODO: Check if autoconnect is enabled and connect?
> -        pass
> +        log.debug('({ip}) Processing LKUP command'.format(ip=self.entry.name))
> +        settings = Settings()

This looks wrong and not the same as the rest of the code.
see how other places do this.

> +        settings.beginGroup(self.settings_section)
> +        autostart = settings.value('connect when LKUP received')
> +        settings.endGroup()
> +        del settings
> +        if autostart:
> +            self.connect_to_host()
>  
> -    def process_name(self, data, *args, **kwargs):
> +    def process_name(self, data):
>          """
>          Projector name set in projector.
>          Updates self.pjlink_name


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-r/+merge/345041
Your team OpenLP Core is subscribed to branch lp:openlp.