openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

The fix for version is not correct see inline notes.


Diff comments:

> 
> === modified file 'openlp/core/version.py'
> --- openlp/core/version.py	2018-03-29 15:54:55 +0000
> +++ openlp/core/version.py	2018-06-28 15:48:46 +0000
> @@ -89,6 +89,10 @@
>          while retries < 3:
>              try:
>                  response = requests.get(download_url, headers=headers)
> +                if response.status_code != 200:

No this is not correct 
if status == 200 then set remote_version otherwise leave as null.
See how I have fixed it in the fonts branch,

> +                    log.warn('Server returned status code {code}: '
> +                             'Version update check not available.'.format(code=response.status_code))
> +                    break
>                  remote_version = response.text.strip()
>                  log.debug('New version found: %s', remote_version)
>                  break


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-s/+merge/348698
Your team OpenLP Core is subscribed to branch lp:openlp.