openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Information

Looks good, just one question, line 521.

Diff comments:

> 
> === modified file 'tests/functional/openlp_core/common/test_init.py'
> --- tests/functional/openlp_core/common/test_init.py	2017-12-28 08:22:55 +0000
> +++ tests/functional/openlp_core/common/test_init.py	2018-07-05 21:06:13 +0000
> @@ -238,13 +238,14 @@
>          Test the clean_filename() function
>          """
>          # GIVEN: A invalid file name and the valid file name.
> -        invalid_name = 'A_file_with_invalid_characters_[\\/:\*\?"<>\|\+\[\]%].py'
> -        wanted_name = 'A_file_with_invalid_characters______________________.py'
> +        invalid_name = 'A_file_with_invalid_characters_[\\/:*?"<>|+[]%].py'
> +        wanted_name = 'A_file_with_invalid_characters________________.py'
>  
>          # WHEN: Clean the name.
>          result = clean_filename(invalid_name)
>  
>          # THEN: The file name should be cleaned.
> +        print(result)

Is this needed,or was it just for debugging?

>          assert wanted_name == result, 'The file name should not contain any special characters.'
>  
>      def test_delete_file_no_path(self):


-- 
https://code.launchpad.net/~tomasgroth/openlp/pycodestyle1/+merge/349024
Your team OpenLP Core is subscribed to branch lp:openlp.