openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #32948
Re: [Merge] lp:~thelinuxguy/openlp/improve-logging into lp:openlp
I'm not convinced that logging an error instead of raising a TypeError is the right approach here... I mean, if someone tries to use the wrong type it should not be allowed and the developer should get the exception and fix it.
I do of course agree that the error message should be improved.
I'll let Phill decide what is better since I believe he wrote the Path code and knows how it should work.
--
https://code.launchpad.net/~thelinuxguy/openlp/improve-logging/+merge/352939
Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/improve-logging into lp:openlp.
References