openlp-core team mailing list archive

[Simon Hanna <1788285@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

openlp.plugins.presentations.lib.mediaitem.PresentationMediaItem.load_list
is messed up

The documentation of the method says it expects a list of Path objects,
but the code treats the parameter as a list of strings.

It's called in the initialize method using a list of strings.

The parent class defines a load_list method but doesn't specify the type of the parameter.
The SongMediaItem for instance doesn't overwrite the method, while others do and use a list of strings.

I didn't look that much into it, but if the load_list method is called
on MediaItems regardless of their actual class, then this could be a
source of errors. Ideally all methods should have the same parameter
type.

** Affects: openlp
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1788285

Title:
  Wrong documentation/implementation

Status in OpenLP:
  New

Bug description:
  openlp.plugins.presentations.lib.mediaitem.PresentationMediaItem.load_list
  is messed up

  The documentation of the method says it expects a list of Path
  objects, but the code treats the parameter as a list of strings.

  It's called in the initialize method using a list of strings.

  The parent class defines a load_list method but doesn't specify the type of the parameter.
  The SongMediaItem for instance doesn't overwrite the method, while others do and use a list of strings.

  I didn't look that much into it, but if the load_list method is called
  on MediaItems regardless of their actual class, then this could be a
  source of errors. Ideally all methods should have the same parameter
  type.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1788285/+subscriptions