openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Approve

I just checked, and the macOS tests also passed, so I'm good to go with this.

Diff comments:

> 
> === modified file 'scripts/check_dependencies.py'
> --- scripts/check_dependencies.py	2018-10-12 22:11:04 +0000
> +++ scripts/check_dependencies.py	2018-10-25 21:32:23 +0000
> @@ -40,8 +40,8 @@
>  
>  VERS = {
>      'Python': '3.6',
> -    'PyQt5': '5.0',
> -    'Qt5': '5.0',
> +    'PyQt5': '5.2',
> +    'Qt5': '5.2',

These should probably be raised to something like 5.9 eventually.

>      'pymediainfo': '2.2',
>      'sqlalchemy': '0.5',
>      'enchant': '1.6'


-- 
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is subscribed to branch lp:openlp.