← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~bastian-germann/openlp/py37 into lp:openlp

 

Bastian Germann has proposed merging lp:~bastian-germann/openlp/py37 into lp:openlp.

Commit message:
A test that depends on re.escape's pre-3.7 behaviour fails on Python 3.7.
Make it compatible.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/py37/+merge/357922
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/py37 into lp:openlp.
=== modified file 'tests/functional/openlp_core/api/http/test_wsgiapp.py'
--- tests/functional/openlp_core/api/http/test_wsgiapp.py	2018-10-27 01:53:43 +0000
+++ tests/functional/openlp_core/api/http/test_wsgiapp.py	2018-10-28 23:34:36 +0000
@@ -69,7 +69,9 @@
         rqst.method = 'GET'
         application.dispatch(rqst)
         # THEN: the not found id called
-        assert 1 == application.route_map['^\\/test\\/image$']['GET'].call_count, \
+        route_key = next(iter(application.route_map))
+        assert '/image' in route_key
+        assert 1 == application.route_map[route_key]['GET'].call_count, \
             'main_index function should have been called'
 
 


Follow ups