openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/media_state into lp:openlp

To: mp+361389@xxxxxxxxxxxxxxxxxx
From: Phill <phill.ridout@xxxxxxxxx>
Date: Wed, 09 Jan 2019 15:17:01 -0000
In-reply-to: <154663598386.29051.15197647036160685182.launchpad@ackee.canonical.com>
Reply-to: mp+361389@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

I assume the commented out code is a work in progress?

L7027: if statement not needed
L7953: I'm not convinced the user will want to see a dialog box every time the preview, go live, or edit a song that has audio....

Also it looks like you've removed the background audio controls from the live slide controller, but not replaced them with anything?


-- 
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361389
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/media_state into lp:openlp
From: Tim Bentley, 2019-01-04