openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Information

See in lines.

Diff comments:

> === modified file 'builders/builder.py'
> --- builders/builder.py	2018-12-02 06:07:08 +0000
> +++ builders/builder.py	2019-02-16 21:23:26 +0000
> @@ -90,6 +90,7 @@
>  
>          Return text from stdout.
>          """
> +        print(cmd)

Intentional?

>          proc = Popen(cmd, stdout=PIPE, stderr=PIPE, universal_newlines=True)
>          output, error = proc.communicate()
>          code = proc.wait()
> 
> === modified file 'builders/windows-builder.py'
> --- builders/windows-builder.py	2016-12-12 19:02:33 +0000
> +++ builders/windows-builder.py	2019-02-16 21:23:26 +0000
> @@ -26,12 +26,11 @@
>  This script is used to build the Windows binary and the accompanying installer.
>  For this script to work out of the box, it depends on a number of things:
>  
> -Python 3.4
> +Python 3.7

Not py3.6?

>  
>  PyQt5
>      You should already have this installed, OpenLP doesn't work without it. The
> -    version the script expects is the packaged one available from River Bank
> -    Computing.
> +    version the script expects is the packaged one available from pypi.
>  
>  PyEnchant
>      This script expects the precompiled, installable version of PyEnchant to be


-- 
https://code.launchpad.net/~tomasgroth/openlp/packaging-webengine/+merge/363286
Your team OpenLP Core is subscribed to branch lp:openlp/packaging.