← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

To: mp+363518@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Mon, 25 Feb 2019 21:27:05 -0000
In-reply-to: <155078516113.18092.18020317840049235393.launchpad@ackee.canonical.com>
Reply-to: mp+363518@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Template should be in its own file so can be tested and not duplicated.
Not happy with the if conditions being removed these have been added as we sometimes get broken databases in the wild and this needs to be guarded against.
-- 
https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/363518
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp
From: Samuel Mehrbrodt, 2019-02-21