openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Fixing

Few minor inlines.

Diff comments:

> === modified file 'openlp/core/projectors/manager.py'
> --- openlp/core/projectors/manager.py	2019-02-14 15:09:09 +0000
> +++ openlp/core/projectors/manager.py	2019-03-08 11:58:35 +0000
> @@ -505,7 +484,8 @@
>                  projector = list_item.data(QtCore.Qt.UserRole)
>                  try:
>                      projector.link.connect_to_host()
> -                except Exception:
> +                except Exception as e:
> +                    print(e)

Please remove print statement. Rather use log.exception('Friendly Error Message')

>                      continue
>  
>      def on_delete_projector(self, opt=None):
> 
> === modified file 'openlp/core/projectors/pjlink.py'
> --- openlp/core/projectors/pjlink.py	2019-02-14 15:09:09 +0000
> +++ openlp/core/projectors/pjlink.py	2019-03-08 11:58:35 +0000
> @@ -905,7 +909,14 @@
>                                                                      message=status_message if msg is None else msg))
>  
>          # Now that we logged extra information for debugging, broadcast the original change/message
> -        (code, message) = self._get_status(status)
> +        # Check for connection errors first
> +        if self.error_status != S_OK:
> +            log.debug('({ip}) Signalling error code'.format(ip=self.entry.name))
> +            (code, message) = self._get_status(self.error_status)

The brackets are surpurflus

> +            status = self.error_status
> +        else:
> +            log.debug('({ip}) Signalling status code'.format(ip=self.entry.name))
> +            (code, message) = self._get_status(status)

Same here

>          if msg is not None:
>              message = msg
>          elif message is None:


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-u/+merge/364148
Your team OpenLP Core is subscribed to branch lp:openlp.