openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Fixing

Sorry, that should have been a needs fixing!

Diff comments:

> 
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py	2019-02-14 15:09:09 +0000
> +++ openlp/core/ui/media/mediacontroller.py	2019-03-27 19:21:41 +0000
> @@ -379,10 +284,10 @@
>              critical_error_message_box(translate('MediaPlugin.MediaItem', 'Unsupported File'),
>                                         translate('MediaPlugin.MediaItem', 'Unsupported File'))
>              return False
> -        log.debug('video mediatype: ' + str(controller.media_info.media_type))
> +        log.debug('video media type: ' + str(controller.media_info.media_type))
>          # dont care about actual theme, set a black background
> -        if controller.is_live and not controller.media_info.is_background:
> -            display.frame.runJavaScript('show_video("setBackBoard", null, null,"visible");')
> +        # if controller.is_live and not controller.media_info.is_background:
> +        #    display.frame.runJavaScript('show_video("setBackBoard", null, null,"visible");')
>          # now start playing - Preview is autoplay!

Should autoplay on preview be optional? It could slow things down on a machine with less resources.

>          autoplay = False
>          # Preview requested


-- 
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365193
Your team OpenLP Core is subscribed to branch lp:openlp.