openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Information

See inline 

Diff comments:

> === modified file 'openlp/core/app.py'
> --- openlp/core/app.py	2019-05-01 19:22:01 +0000
> +++ openlp/core/app.py	2019-05-04 18:27:23 +0000
> @@ -287,12 +287,12 @@
>          return QtWidgets.QApplication.event(self, event)
>  
>  
> -def parse_options(args=None):

Have you tested desktop drag and drop of service files to openlp.exe on the desktop?

> +def parse_options():
>      """
>      Parse the command line arguments
>  
> -    :param args: list of command line arguments
> -    :return: a tuple of parsed options of type optparse.Value and a list of remaining argsZ
> +    :return: An :object:`argparse.Namespace` insatnce containing the parsed args.
> +    :rtype: argparse.Namespace
>      """
>      # Set up command line options.
>      parser = argparse.ArgumentParser(prog='openlp')
> 
> === modified file 'openlp/core/ui/mainwindow.py'
> --- openlp/core/ui/mainwindow.py	2019-04-13 13:00:22 +0000
> +++ openlp/core/ui/mainwindow.py	2019-05-04 18:27:23 +0000
> @@ -475,7 +475,6 @@
>          super(MainWindow, self).__init__()
>          Registry().register('main_window', self)
>          self.clipboard = self.application.clipboard()
> -        self.arguments = ''.join(self.application.args)

This was for desktop drag and drop.

>          # Set up settings sections for the main application (not for use by plugins).
>          self.ui_settings_section = 'user interface'
>          self.general_settings_section = 'core'


-- 
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366951
Your team OpenLP Core is subscribed to branch lp:openlp.