openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Fixing

You have quite a few "assert (chk == E_NO_AUTHENTICATION), '....'" the brackets are not needed.

Also you're "@patch.object(openlp.core.projectors.pjlinkcommands, 'log')" a lot, have you considered putting it in the setUp method?

Other than that looks good to me!
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v07/+merge/367304
Your team OpenLP Core is subscribed to branch lp:openlp.