openlp-core team mailing list archive

[Tomas Groth <second@xxxxxx>]

Review: Needs Fixing

Nothing majer

Diff comments:

> 
> === added file 'pyinstaller-hooks/hook-openlp.plugins.presentations.lib.maclocontroller.py'
> --- pyinstaller-hooks/hook-openlp.plugins.presentations.lib.maclocontroller.py	1970-01-01 00:00:00 +0000
> +++ pyinstaller-hooks/hook-openlp.plugins.presentations.lib.maclocontroller.py	2019-05-22 21:58:47 +0000
> @@ -0,0 +1,23 @@
> +# -*- coding: utf-8 -*-
> +# vim: autoindent shiftwidth=4 expandtab textwidth=80 tabstop=4 softtabstop=4
> +
> +###############################################################################
> +# OpenLP - Open Source Lyrics Projection                                      #
> +# --------------------------------------------------------------------------- #
> +# Copyright (c) 2008-2015 OpenLP Developers                                   #

We're in 2019 ;)

> +# --------------------------------------------------------------------------- #
> +# This program is free software; you can redistribute it and/or modify it     #
> +# under the terms of the GNU General Public License as published by the Free  #
> +# Software Foundation; version 2 of the License.                              #
> +#                                                                             #
> +# This program is distributed in the hope that it will be useful, but WITHOUT #
> +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or       #
> +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for    #
> +# more details.                                                               #
> +#                                                                             #
> +# You should have received a copy of the GNU General Public License along     #
> +# with this program; if not, write to the Free Software Foundation, Inc., 59  #
> +# Temple Place, Suite 330, Boston, MA 02111-1307 USA                          #
> +###############################################################################
> +
> +hiddenimports = ['Pyro4']
> 
> === modified file 'pyinstaller-hooks/hook-openlp.plugins.presentations.presentationplugin.py'
> --- pyinstaller-hooks/hook-openlp.plugins.presentations.presentationplugin.py	2015-06-16 20:07:34 +0000
> +++ pyinstaller-hooks/hook-openlp.plugins.presentations.presentationplugin.py	2019-05-22 21:58:47 +0000
> @@ -21,6 +21,7 @@
>  ###############################################################################
>  
>  hiddenimports = ['openlp.plugins.presentations.lib.impresscontroller',
> +                 'openlp.plugins.presentations.lib.maclocontroller',

The other new files does not need to be listed?

>                   'openlp.plugins.presentations.lib.pdfcontroller',
>                   'openlp.plugins.presentations.lib.powerpointcontroller',
>                   'openlp.plugins.presentations.lib.pptviewcontroller']


-- 
https://code.launchpad.net/~raoul-snyman/openlp/packaging-macos-pyro/+merge/367808
Your team OpenLP Core is subscribed to branch lp:openlp/packaging.