openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Whats happrning with the commented out code?

Diff comments:

> 
> === modified file 'openlp/plugins/presentations/lib/impresscontroller.py'
> --- openlp/plugins/presentations/lib/impresscontroller.py	2019-04-13 13:00:22 +0000
> +++ openlp/plugins/presentations/lib/impresscontroller.py	2019-05-23 20:31:03 +0000
> @@ -483,3 +560,100 @@
>                  note = ' '
>              notes.append(note)
>          self.save_titles_and_notes(titles, notes)
> +
> +        if is_win():
> +            property_object = self.controller.manager.Bridge_GetStruct('com.sun.star.beans.PropertyValue')
> +
> +
> +class SlideShowListener(SlideShowListenerImport):
> +    """
> +    Listener interface to receive global slide show events.
> +    """
> +
> +    def __init__(self, document):
> +        """
> +        Constructor
> +
> +        :param document: The ImpressDocument being presented
> +        """
> +        self.document = document
> +
> +    def paused(self):
> +        """
> +        Notify that the slide show is paused
> +        """
> +        log.debug('LibreOffice SlideShowListener event: paused')
> +
> +    def resumed(self):
> +        """
> +        Notify that the slide show is resumed from a paused state
> +        """
> +        log.debug('LibreOffice SlideShowListener event: resumed')
> +
> +    def slideTransitionStarted(self):
> +        """
> +        Notify that a new slide starts to become visible.
> +        """
> +        log.debug('LibreOffice SlideShowListener event: slideTransitionStarted')
> +
> +    def slideTransitionEnded(self):
> +        """
> +        Notify that the slide transtion of the current slide ended.
> +        """
> +        log.debug('LibreOffice SlideShowListener event: slideTransitionEnded')
> +
> +    def slideAnimationsEnded(self):
> +        """
> +        Notify that the last animation from the main sequence of the current slide has ended.
> +        """
> +        log.debug('LibreOffice SlideShowListener event: slideAnimationsEnded')
> +        # if not Registry().get('main_window').isActiveWindow():

Commented out code?

> +        #    log.debug('main window is not in focus - should update slidecontroller')
> +        #    Registry().execute('slidecontroller_live_change', self.document.control.getCurrentSlideIndex() + 1)
> +
> +    def slideEnded(self, reverse):
> +        """
> +        Notify that the current slide has ended, e.g. the user has clicked on the slide. Calling displaySlide()
> +        twice will not issue this event.
> +        """
> +        log.debug('LibreOffice SlideShowListener event: slideEnded %d' % reverse)
> +        if reverse:
> +            self.document.slide_ended = False
> +            self.document.slide_ended_reverse = True
> +        else:
> +            self.document.slide_ended = True
> +            self.document.slide_ended_reverse = False
> +
> +    def hyperLinkClicked(self, hyperLink):
> +        """
> +        Notifies that a hyperlink has been clicked.
> +        """
> +        log.debug('LibreOffice SlideShowListener event: hyperLinkClicked %s' % hyperLink)
> +
> +    def disposing(self, source):
> +        """
> +        gets called when the broadcaster is about to be disposed.
> +        :param source:
> +        """
> +        log.debug('LibreOffice SlideShowListener event: disposing')
> +
> +    def beginEvent(self, node):
> +        """
> +        This event is raised when the element local timeline begins to play.
> +        :param node:
> +        """
> +        log.debug('LibreOffice SlideShowListener event: beginEvent')
> +
> +    def endEvent(self, node):
> +        """
> +        This event is raised at the active end of the element.
> +        :param node:
> +        """
> +        log.debug('LibreOffice SlideShowListener event: endEvent')
> +
> +    def repeat(self, node):
> +        """
> +        This event is raised when the element local timeline repeats.
> +        :param node:
> +        """
> +        log.debug('LibreOffice SlideShowListener event: repeat')


-- 
https://code.launchpad.net/~tomasgroth/openlp/presentation-beyond-last/+merge/367863
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/presentation-beyond-last into lp:openlp.