openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Just a comment on implementation.

Diff comments:

> 
> === modified file 'openlp/core/ui/servicemanager.py'
> --- openlp/core/ui/servicemanager.py	2019-05-24 18:50:51 +0000
> +++ openlp/core/ui/servicemanager.py	2019-05-27 18:44:30 +0000
> @@ -509,7 +510,8 @@
>          service = []
>          core = {
>              'lite-service': self._save_lite,
> -            'service-theme': self.service_theme
> +            'service-theme': self.service_theme,
> +            'openlp-servicefile-version': 3.0

Not a fan of the name, wouldn't 'version' suffice, or using floats or the OpenLP version number.

If we use floats, what happens if we need to make a change in say 3.0.1? Secondly if we change the version of OpenLP we then need to change the version of the service file. I would much rather go with the incremental versioning scheme we already use for the databases and settings class

>          }
>          service.append({'openlp_core': core})
>          return service


-- 
https://code.launchpad.net/~tomasgroth/openlp/presentation-load-speedup/+merge/367933
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/presentation-load-speedup into lp:openlp.