openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Fixing

Just one inconsistency with text labels (see inline) and the failed linting, but other than that looks ok!

Diff comments:

> 
> === modified file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py	2019-05-04 19:47:06 +0000
> +++ openlp/core/ui/media/mediatab.py	2019-06-14 18:00:17 +0000
> @@ -68,11 +68,15 @@
>          self.left_layout.addWidget(self.live_media_group_box)
>          self.stream_media_group_box = QtWidgets.QGroupBox(self.left_column)
>          self.stream_media_group_box.setObjectName('stream_media_group_box')
> -        self.stream_media_layout = QtWidgets.QHBoxLayout(self.stream_media_group_box)
> +        self.stream_media_layout = QtWidgets.QFormLayout(self.stream_media_group_box)
>          self.stream_media_layout.setObjectName('stream_media_layout')
>          self.stream_media_layout.setContentsMargins(0, 0, 0, 0)
> -        self.stream_edit = QtWidgets.QLabel(self)
> -        self.stream_media_layout.addWidget(self.stream_edit)
> +        self.video_edit = QtWidgets.QLineEdit(self)
> +        self.stream_media_layout.addRow(translate('MediaPlugin.MediaTab', 'Video:'), self.video_edit)

colon here

> +        self.audio_edit = QtWidgets.QLineEdit(self)
> +        self.stream_media_layout.addRow(translate('MediaPlugin.MediaTab', 'Audio'), self.audio_edit)

but not here

> +        self.stream_cmd = QtWidgets.QLabel(self)
> +        self.stream_media_layout.addWidget(self.stream_cmd)
>          self.left_layout.addWidget(self.stream_media_group_box)
>          self.vlc_arguments_group_box = QtWidgets.QGroupBox(self.left_column)
>          self.vlc_arguments_group_box.setObjectName('vlc_arguments_group_box')


-- 
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841
Your team OpenLP Core is subscribed to branch lp:openlp.