openlp-core team mailing list archive

[Tomas Groth <second@xxxxxx>]

Review: Needs Information

Just a question inline, otherwise it looks fine.

Diff comments:

> 
> === modified file 'openlp/core/common/i18n.py'
> --- openlp/core/common/i18n.py	2019-06-28 18:09:25 +0000
> +++ openlp/core/common/i18n.py	2019-07-18 19:27:49 +0000
> @@ -338,8 +338,8 @@
>          Override the default object creation method to return a single instance.
>          """
>          if not cls.__instance__:
> -            cls.__instance__ = object.__new__(cls)
> -            cls.load(cls)
> +            cls.__instance__ = super().__new__(cls)
> +            cls.__instance__.load()

Are you sure this is correct? I haven't tested it, but in the old code an instance of the "current" class was created, while the new code creates an instance of the super class.

>          return cls.__instance__
>  
>      def load(self):


-- 
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370337
Your team OpenLP Core is subscribed to branch lp:openlp.