openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/pymysql into lp:openlp.

Commit message:
Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL client.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371825

Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL client.
-- 
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp.

=== modified file 'openlp/core/lib/db.py'
--- openlp/core/lib/db.py	2019-07-03 13:23:23 +0000
+++ openlp/core/lib/db.py	2019-08-26 21:39:23 +0000
@@ -67,7 +67,7 @@
         create_database(engine.url)
         database_exists(engine.url)  #=> True
 
-    Borrowed from SQLAlchemy_Utils (v0.32.14 )since we only need this one function.
+    Borrowed from SQLAlchemy_Utils (v0.32.14) since we only need this one function.
     """
 
     url = copy(make_url(url))

=== modified file 'scripts/check_dependencies.py'
--- scripts/check_dependencies.py	2019-07-01 22:48:52 +0000
+++ scripts/check_dependencies.py	2019-08-26 21:39:23 +0000
@@ -97,7 +97,7 @@
 
 OPTIONAL_MODULES = [
     ('qdarkstyle', '(dark style support)'),
-    ('mysql.connector', '(MySQL support)'),
+    ('pymysql', '(MySQL support)'),
     ('pyodbc', '(ODBC support)'),
     ('psycopg2', '(PostgreSQL support)'),
     ('enchant', '(spell checker)'),

=== modified file 'setup.py'
--- setup.py	2019-07-02 20:29:42 +0000
+++ setup.py	2019-08-26 21:39:23 +0000
@@ -191,7 +191,7 @@
     extras_require={
         'agpl-pdf': ['PyMuPDF'],
         'darkstyle': ['QDarkStyle'],
-        'mysql': ['mysql-connector-python'],
+        'mysql': ['pymysql'],
         'odbc': ['pyodbc'],
         'postgresql': ['psycopg2'],
         'spellcheck': ['pyenchant >= 1.6'],