openlp-core team mailing list archive

[Tomas Groth <second@xxxxxx>]

Review: Needs Fixing

Hi John, sorry for mentioning this before, but the hint file should be placed in the folder openlp/plugins/songs/lib/importers/
If the user does not supply a hint file you can then load it from this path:
AppLocation.get_directory(AppLocation.PluginsDir) / 'songs' / 'lib' / 'importers' / 'singingthefaith-hints.tag'
As you can see I would recommend renaming it to 'singingthefaith-hints.tag' or something similar to make it easy to see what it is used for.
And please set 'SongbookNumberInTitle' in the default hint file to False.
-- 
https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372194
Your team OpenLP Core is subscribed to branch lp:openlp.