openlp-dev team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Overall, this looks fine, but there are a couple issues.

- Your tests don't actually test anything. For example, when testing alertEntranceTransition, you need to check that the #alert-background div styles are updated.
- You've got a lot of debug statements, you can remove some of them.
- Can you rename your "alert...Transition" functions to something that's action-orientated and descriptive? For instance: doEntranceTransition, doExitTransition.
-- 
https://code.launchpad.net/~ic90/openlp/animated-alerts/+merge/362182
Your team OpenLP Development is subscribed to branch lp:~openlp-dev/openlp/webengine-migrate.