openlp-dev team mailing list archive

[Nico Opiyo <gregzovic@xxxxxxxxx>]

The proposal to merge lp:~ic90/openlp/animated-alerts into lp:~openlp-dev/openlp/webengine-migrate has been updated.

Description changed to:

I have fixed the tests to test the various components added to the UI and also made some slight adjustments to the entrance transition and fixed a glitch when an alert is first displayed on opening the program.

JS Test Output is as below:
PhantomJS 2.1.1 (Windows 8.0.0) Display.setTextSlides should correctly set outline width FAILED
        TypeError: undefined is not an object (evaluating 'dom.wrapper.querySelectorAll') in openlp/core/display/html/reveal.js (line 2304)
        slide@openlp/core/display/html/reveal.js:2304:37
        goToSlide@openlp/core/display/html/display.js:694:19
        setTextSlides@openlp/core/display/html/display.js:551:22
        tests/js/test_display.js:404:26
PhantomJS 2.1.1 (Windows 8.0.0): Executed 78 of 78 (1 FAILED) (0 secs / 0.087 secs)
PhantomJS 2.1.1 (Windows 8.0.0): Executed 78 of 78 (1 FAILED) (0.108 secs / 0.087 secs)
TOTAL: 1 FAILED, 77 SUCCESS

For more details, see:
https://code.launchpad.net/~ic90/openlp/animated-alerts/+merge/362833
-- 
Your team OpenLP Development is requested to review the proposed merge of lp:~ic90/openlp/animated-alerts into lp:~openlp-dev/openlp/webengine-migrate.