openobject-italia-core-devs team mailing list archive

[Lorenzo Battistini - Agile BG <lorenzo.battistini@xxxxxxxxxxx>]

Review: Needs Fixing

Mi pare di capire che la registrazione di write-off venga scritta ogni volta che
voucher.amount != invoice.net_pay
( http://bazaar.launchpad.net/~enlightx/openobject-italia/7.0_fix_1261357/view/237/l10n_it_withholding_tax/account.py#L361 )
indipendentemente dal campo 'payment_option'.

Mi sembra sbagliato, infatti, se 'payment difference' viene lasciato su 'Keep Open' e si prova a pagare un importo diverso dal 'net pay', si ottiene

  File "/home/elbati/workspace/openerp/7.0/addons/account_voucher/account_voucher.py", line 936, in proforma_voucher
    self.action_move_line_create(cr, uid, ids, context=context)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/addons/l10n_it_withholding_tax/account.py", line 385, in action_move_line_create
    cr, uid, wo_move, context=context)
  File "/home/elbati/workspace/openerp/7.0/addons/account/account.py", line 1438, in create
    result = super(account_move, self).create(cr, uid, vals, c)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/orm.py", line 4489, in create
    result += self._columns[field].set(cr, self, id_new, field, vals[field], user, rel_context) or []
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/fields.py", line 559, in set
    id_new = obj.create(cr, user, act[2], context=context)
  File "/home/elbati/workspace/openerp/7.0/addons/account/account_move_line.py", line 1144, in create
    if ('account_id' in vals) and not account_obj.read(cr, uid, vals['account_id'], ['active'])['active']:
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/orm.py", line 3623, in read
    result = self._read_flat(cr, user, select, fields, context, load)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/orm.py", line 3675, in _read_flat
    cr.execute(query, [tuple(sub_ids)] + rule_params)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/sql_db.py", line 161, in wrapper
    return f(self, *args, **kwargs)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/sql_db.py", line 226, in execute
    res = self._obj.execute(query, params)
ProgrammingError: operator does not exist: integer = boolean
LINE 1: ...d FROM "account_account" WHERE account_account.id IN (false)...
                                                             ^
HINT:  No operator matches the given name and argument type(s). You might need to add explicit type casts.


Credo che la creazione della registrazione di writeoff debba essere forzata solo nel caso 'reconcile payment balance'.


Inoltre, per la generazione della scrittura di write-off, magari si riescono a usare metodi del voucher tipo 'writeoff_move_line_get'?
-- 
https://code.launchpad.net/~enlightx/openobject-italia/7.0_fix_1261357/+merge/199294
Your team OpenERP Italia core devs is subscribed to branch lp:openobject-italia/7.0.