opensand team mailing list archive

[Jedrzej Gorski <andy.gorski.dev@xxxxxxxxx>]

Hi Dider,


>> > The first task (renaming ATM-related code) is an "easy" one. It is
>> > listed in the TODO list [1]. The problem is that the naming of the
>> > AAL5/ATM plugin is not consistent: sometimes it is named ATM/AAL5 or
>> > AAL5/ATM, sometimes ATM only. The task is: always name it AAL5/ATM.
>> >
>> > The steps for this task are:
>> > [...]
>> >
>> > If you have questions about any of the above steps, please tell me!
>>
>> Did you make some progress during the week?
>>
>
After some time with project documentation (mainly "dev manual" and "coding
rules") my preparation are done and I'm working on my task now.

In order to perform my task I decide to track any name which doesn't look
as AAL5/ATM.
As I said in last email I came up with some questions as usual :) Here you
go:

1. First of all what is a true nature of ATM and AAL5 coexistence in this
project? It will help me understand better why you have to relay on this
transformation.
As far as I know AAL5 stands for ATM Adaptation Layer (from level 1 to 5).
I guess we use level 5 to implement a specific procedure which defines
segment and reassemble higher-layer packets into ATM cells. I presume that
algorithm is working fine. Only inconsistency with naming is an issue.

So far I've found that following files needs our attention:

*opensand-trunk/opensand-plugins/atm/src/*

   - Atm.cpp
   - atm_aal5.py
   - atm_support.py
   - Makefile (header)

*opensand-trunk/opensand-plugins/gse/src/*

   - Gse.cpp
   - gse.py

*opensand-trunk/opensand-plugins/mpeg/src/*

   - Mpeg.cpp
   - mpeg.py   ....

Checking each of folder one by one is a pain in the bottom :) So I decide
to use something more sophisticated - which is quite obvious in that case:)

grep -rl "ATM/AAL5" /home/andyg/opensand-trunk/

Results are in the attached file. It's looks like there is quite a lot of
files to update. I checked only half of it so far.

For the other phrase ("AAL5/ATM") I have found nothing:

Search through phrase "ATM" is point less (to many results).
My question is in what situation this phrase can be replaced by "AAL5/ATM"
??


2. Is there any area where information about ATM or AAL5 shouldn't stay as
it is (simply ATM or AAL5)?
I asked about it because you mention before that the issue is not only
related to changes from ATM/AAL5 to  AAL5/ATM. It's also related to ATM
only.
Based on my code research I can say that they are some sources which are
related only to ATM functionality, and they are separate from AAL5
extension (modular approach). I presume that most of this is an area where
changes shouldn't be made.

Thanks for help in advance,

Andy

Attachment: search
Description: Binary data