opensand team mailing list archive

[Didier Barvaux <didier.barvaux@xxxxxxxxxxxxxxxxxxxx>]

Hello all!

> - The outcoming/incoming throughputs should be renamed with more 
> explicit names. I suggest the generic naming:
> direction_layer_throughput
> with direction={reception/emission}
> with layer={L3, L2, L1}

Not sure that using the Ln naming is the best option. The numbering of
layers is quite relative these days. Is IPv4/IPv6 still layer 3 when
you use phy/DVB/GSE/ATM/AAL5/IP stack? :)

I would replace Ln by a more descriptive name. The new probe system
supports dynamic declaration of probe, so the name can be decided
during initialization when the configuration is parsed:
 - emission_ip_throughput
 - reception_ip_throughput
 - reception_aal5_atm_throughput
 - reception_gse_throughput
 - reception_dvb_throughput
 - reception_phy_throughput
 - ...

With the upcoming physical layer with error models, new probes could be
dynamically registered if the block is enabled (before/after are
examples, they could be replaced by something best):
 - emission_phy_before_throughput
 - emission_phy_after_throughput
 - reception_phy_before_throughput
 - reception_phy_after_throughput

Regards,
Didier