openshot.bugs team mailing list archive

[Johannes Schuh <1871057@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

OS: Win10 1909 x64
Installer
2.5.1

Log:
 main_window:INFO ---------------- Shutting down -----------------
  exceptions:ERROR Unhandled Exception
Traceback (most recent call last):
  File "C:\Program Files\OpenShot\windows\main_window.py", line 135, in closeEvent
    self.save_settings()
  File "C:\Program Files\OpenShot\windows\main_window.py", line 2112, in save_settings
    s.set('docks_frozen', self.docks_frozen)
  File "C:\Program Files\OpenShot\classes\settings.py", line 76, in set
    list(self._data.keys())))
AttributeError: 'list' object has no attribute 'keys'

Broken Stuff:
        # Save setting
        if key in user_values:
            user_values[key]["value"] = value
        else:
            log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
                                                                                 list(self._data.keys())))

Fixed Stuff:
        # Save setting
        if key in user_values:
            user_values[key]["value"] = value
        else:
            log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
                                                                                 ', '.join([i['setting'] for i in self._data])))

** Affects: openshot
     Importance: Undecided
         Status: New

** Description changed:

  OS: Win10 1909 x64
  Installer
  2.5.1
  
  Log:
-  main_window:INFO ---------------- Shutting down -----------------
-   exceptions:ERROR Unhandled Exception
+  main_window:INFO ---------------- Shutting down -----------------
+   exceptions:ERROR Unhandled Exception
  Traceback (most recent call last):
-   File "C:\Program Files\OpenShot\windows\main_window.py", line 135, in closeEvent
-     self.save_settings()
-   File "C:\Program Files\OpenShot\windows\main_window.py", line 2112, in save_settings
-     s.set('docks_frozen', self.docks_frozen)
-   File "C:\Program Files\OpenShot\classes\settings.py", line 76, in set
-     list(self._data.keys())))
+   File "C:\Program Files\OpenShot\windows\main_window.py", line 135, in closeEvent
+     self.save_settings()
+   File "C:\Program Files\OpenShot\windows\main_window.py", line 2112, in save_settings
+     s.set('docks_frozen', self.docks_frozen)
+   File "C:\Program Files\OpenShot\classes\settings.py", line 76, in set
+     list(self._data.keys())))
  AttributeError: 'list' object has no attribute 'keys'
  
  Broken Stuff:
-         # Save setting
-         if key in user_values:
-             user_values[key]["value"] = value
-         else:
-             log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
-                                                                                  list(self._data.keys())))
+         # Save setting
+         if key in user_values:
+             user_values[key]["value"] = value
+         else:
+             log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
+                                                                                  list(self._data.keys())))
  
  Fixed Stuff:
          # Save setting
          if key in user_values:
              user_values[key]["value"] = value
          else:
              log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
-                                                                                  list(self._data.keys())))
+                                                                                  ', '.join([i['setting'] for i in self._data])))

-- 
You received this bug notification because you are a member of OpenShot
Bugs, which is subscribed to OpenShot Video Editor.
https://bugs.launchpad.net/bugs/1871057

Title:
  does not close on windows because docks_frozen setting missing and bug
  in log statement

Status in OpenShot Video Editor:
  New

Bug description:
  OS: Win10 1909 x64
  Installer
  2.5.1

  Log:
   main_window:INFO ---------------- Shutting down -----------------
    exceptions:ERROR Unhandled Exception
  Traceback (most recent call last):
    File "C:\Program Files\OpenShot\windows\main_window.py", line 135, in closeEvent
      self.save_settings()
    File "C:\Program Files\OpenShot\windows\main_window.py", line 2112, in save_settings
      s.set('docks_frozen', self.docks_frozen)
    File "C:\Program Files\OpenShot\classes\settings.py", line 76, in set
      list(self._data.keys())))
  AttributeError: 'list' object has no attribute 'keys'

  Broken Stuff:
          # Save setting
          if key in user_values:
              user_values[key]["value"] = value
          else:
              log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
                                                                                   list(self._data.keys())))

  Fixed Stuff:
          # Save setting
          if key in user_values:
              user_values[key]["value"] = value
          else:
              log.warn("{} key '{}' not valid. The following are valid: {}".format(self.data_type, key,
                                                                                   ', '.join([i['setting'] for i in self._data])))

To manage notifications about this bug go to:
https://bugs.launchpad.net/openshot/+bug/1871057/+subscriptions