← Back to team overview

openshot.developers team mailing list archive

Re: Update on Integrating TJ's Changes

 

Hi TJ
Thanks for your fast answers.
So it's like the answer of Helen.
A ppa for jaunty a ppa for karmic and a ppa "testing" for us (and the
"couragous") in your ppa-video
Olivier, thanks


2009/9/4 TJ <ubuntu@xxxxxxxxxxx>

> On Fri, 2009-09-04 at 15:40 +0200, Olivier Girard wrote:
> > Hello TJ
> >
> > i've seen that and i want to ask a question.
> > Is it the last step before the PPA
>
> Yes, once Jonathan is happy we can publish a package to the PPA for
> easier widespread installation by Ubuntu users.
>
> >  and the version 1.0.0 too ? or there will lhave some others steps
> > before ?
>
> No, I doubt that. You'll have to ask Jonathan for the specific goals
> that have to be met to declare version 1.0.
>
> > THe binairies which in your Video ppa will be the same that the
> > openshot ppa ?
>
> Once the openshot package is in the OpenShot PPA what I shall do is use
> my own video-editors PPA to publish advanced test versions of the
> supporting libraries and openshot before they get 'promoted' to the
> OpenShot PPA - that way, as developers, we should test from my
> video-editors PPA and if happy with stability and finding no
> regressions, I can copy over the dependency packages.
>
> I'd suggest only updating the OpenShot PPA once every couple of weeks or
> less - maybe once a month - so that we provide some stability and
> predictability to end users.
>
> > Thanks, Olivier
> >
> > 2009/9/4 TJ <ubuntu@xxxxxxxxxxx>
> >         On Fri, 2009-09-04 at 00:59 -0500, Jonathan Thomas wrote:
> >         > TJ,
> >         > I have spent a few hours tonight reviewing all of the
> >         changes.  I am
> >         > working through integrating your branch into the trunk, so
> >         please
> >         > don't make any further commits to your branch (for the time
> >         being).
> >
> >
> >         No, I wasn't planning on doing any other code work until TRUNK
> >         is
> >         ready :)
> >
> >         >
> >         > Here are my initial findings:
> >         > 1) I have no problems with the restructuring of folders /
> >         files,
> >         > etc...  Nice Job!
> >         > 2) The biggest issue:  the global variables do not fit with
> >         the design
> >         > of OpenShot.  In the spirit of keeping everything object
> >         oriented, and
> >         > to fix many issues that global variables create in my local
> >         debug
> >         > environment, I've moved your global PATH variables (and a
> >         few folder
> >         > checking methods) into the project class.
> >
> >
> >         That sounds sensible. I think I left them as globals since I
> >         originally
> >         put them in the launcher, then had some weird issues with the
> >         imports
> >         not 'finding' them (probably due to that major 'import' vs
> >         'from'
> >         problem detailed in my r200 commit) and forgot to OO them
> >         later.
> >
> >         > 3) There were some indention inconsistanceis.  I've
> >         converted all of
> >         > the spaces into tabs, to be consistant with the rest of
> >         OpenShot
> >
> >
> >         I found originally that some source files had spaces and some
> >         had tabs.
> >         I always prefer spaces and I checked the Python style guide,
> >         PEP 8, and
> >         it strongly recommends using spaces.
> >
> >         Once the branches had merged I was going to suggest, as the
> >         first thing,
> >         a white-space clean up :)
> >
> >         > 4) There are some PATHs that are being mapped incorrectly,
> >         which
> >         > causes some dialogs to not launch
> >
> >
> >         I thought there might be one or two, but since I'd not seen
> >         the
> >         application running fully prior to the refactoring I couldn't
> >         be sure.
> >
> >
> >         > and lots of regression testing I need to do.  I also have a
> >         few more
> >         > changes that I need to integrate into the code (some of the
> >         newer
> >         > commits).
> >
> >
> >         It would make sense to add unit tests to the project as each
> >         bit of
> >         functionality is added to ensure code quality to help automate
> >         this kind
> >         of assurance in the future.
> >
> >         > Give me another day (time permitting), and hopefully I'll be
> >         ready to
> >         > commit these changes to the trunk.
> >
> >         > Thanks for your help TJ!
> >
> >
> >         I'm looking forward to being able to do some 'real' coding on
> >         functionality after this learning curve :)
> >
> >
> >         _______________________________________________
> >         Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> >         Post to     : openshot.developers@xxxxxxxxxxxxxxxxxxx
> >         Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> >         More help   : https://help.launchpad.net/ListHelp
> >
> >
> >
> > --
> > Cenwen un elfe sur la banquise
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to     : openshot.developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Cenwen un elfe sur la banquise

References