← Back to team overview

openstack-poc team mailing list archive

[Bug 965563] Re: Usability issue: is_public=yes sets Public: No


Reviewed:  https://review.openstack.org/5908
Committed: http://github.com/openstack/glance/commit/9b682439815e7c397c5fe2ec10b4cbfec7e13336
Submitter: Jenkins
Branch:    milestone-proposed

commit 9b682439815e7c397c5fe2ec10b4cbfec7e13336
Author: Brian Waldon <bcwaldon@xxxxxxxxx>
Date:   Tue Mar 27 09:44:49 2012 -0700

    Allow yes-like values to be interpreted as bool
    * Accept 'YES', 'yes', 'Y' and 'y'
    * Remove duplicate function bool_from_header_value
    * Fixes bug 965563
    Change-Id: I593a50117fd339a8ab281a8daad734770ca9960c

** Changed in: glance
       Status: Fix Committed => Fix Released

You received this bug notification because you are a member of OpenStack
Common Drivers, which is the registrant for openstack-common.

  Usability issue: is_public=yes sets Public: No

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released
Status in openstack-common:

Bug description:
  There is a usability with Glance around the use of booleans. The
  is_public metadata for an image is displayed via "glance show" in
  Yes/No terms. i.e.

  Id: 7b1ee878-131b-4c1e-bd14-dc8cb0e48ace
  Public: Yes
  Protected: No
  Name: oneiric-11.10-2
  Status: active
  Size: 10486808576

  However the bool_from_string function (common/utils.py) doesn't define
  'yes' as true.

  This results in the flag is_public=yes actually setting Public: No in
  the image.

  I suggest that 'yes' is added to the list of values considered true.
  There is a proposed change for it here -
  https://review.openstack.org/#change,5712 that would go into common,
  then we could propogate it out to glance proper.

To manage notifications about this bug go to: